Remove Deprecated code#73
Merged
Merged
Conversation
Contributor
Author
psavery
approved these changes
Jan 7, 2026
psavery
left a comment
psavery
left a comment
Collaborator
There was a problem hiding this comment.
I'd recommend testing it first (I probably won't get a chance) but it looks fine to me.
Contributor
Author
|
I'm afraid I will not be able to test anything either. |
Contributor
|
Sorry for the delayed reaction. I can probably test it this week (I'm at the Slicer project week and have a Looking Glass with me but struggling with the build). If you can wait a bit more I can help verify this change doesn't break things, at least with this one device model |
|
I tested this on the Looking Glass Go and it worked completely fine for me! |
Collaborator
|
Merged, thanks @skere! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(untested locally, feel free to merge)